• Kan Liang's avatar
    perf/x86/intel: Fix incorrect lbr_sel_mask value · cf3beb7c
    Kan Liang authored
    This patch fixes a bug which was introduced by:
    
     b16a5b52 ("perf/x86: Add option to disable reading branch flags/cycles")
    
    In this patch, lbr_sel_mask is used to mask the lbr_select. But LBR_SEL_MASK
    doesn't include the bit for LBR_CALL_STACK. So LBR call stack will never be
    set in lbr_select.
    
    This patch corrects the LBR_SEL_MASK by including all valid bits in
    LBR_SELECT. Also, the LBR_CALL_STACK bit is different as other bit in
    LBR_SELECT. It does not operate in suppress mode, so it needs to be
    specially handled in intel_pmu_setup_hw_lbr_filter.
    Signed-off-by: default avatarKan Liang <kan.liang@intel.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vince Weaver <vincent.weaver@maine.edu>
    Link: http://lkml.kernel.org/r/1461231010-4399-1-git-send-email-kan.liang@intel.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    cf3beb7c
lbr.c 26.7 KB