• Tero Jaasko's avatar
    arm: kirkwood: add support for ZyXEL NSA310 · afcad884
    Tero Jaasko authored
    Hello, Andrew
    
    > > +#define NSA310_GPIO_LED_ESATA_GREEN	12
    > > <..>
    > > +#define NSA310_GPIO_POWER_OFF		48
    >
    > It looks like most of these are not used. Please remove them.
    
    True. Fixed.
    
    > > +static struct mtd_partition nsa310_mtd_parts[] = {
    > > +	{
    > > +		.name	= "uboot",
    > > +		.offset	= 0,
    > > +		.size	= 0x100000,
    > > +		.mask_flags = MTD_WRITEABLE,
    > > +	}, {
    > > <..>
    > You should be able to put all that into DT. Take a look at
    
    Correct. I did the conversion and tested that the partitions
    can be read with dd and produce exactly the same data before and
    after conversion. So, the partition offsets at least should be fine.
    
    > > +static struct i2c_board_info __initdata nsa310_i2c_info[] = {
    > > +	{ I2C_BOARD_INFO("adt7476", 0x2e) },
    > > +};
    >
    > You can also do this in DT as well. kirkwood-ts219.dtsi has
    >
    >                 i2c@11000 {
    >                         status = "okay";
    >                         clock-frequency = <400000>;
    
    Ok, I did convert the i2c definition to use the devicetree.
    The adt7476 device itself is not at reach of device tree,
    AFAIK and requires more work at there?
    
    Thanks for your valuable comments. Following is a new patch that
    should address the problems and mistakes you pointed and also
    some of the pointed by Jason Cooper. The nand and i2c are now
    defined at DT and I also removed the pointless defines and
    ARM_APPENDED_DTB. It is based against the Linus' official
    3.6 version.
    
    Best regards,
    Tero
    Signed-off-by: default avatarJason Cooper <jason@lakedaemon.net>
    afcad884
kirkwood-nsa310.dts 2.41 KB