• Piotr Jaroszynski's avatar
    iomap: get/put the page in iomap_page_create/release() · d23792f5
    Piotr Jaroszynski authored
    [ Upstream commit 8e47a457 ]
    
    migrate_page_move_mapping() expects pages with private data set to have
    a page_count elevated by 1.  This is what used to happen for xfs through
    the buffer_heads code before the switch to iomap in commit 82cb1417
    ("xfs: add support for sub-pagesize writeback without buffer_heads").
    Not having the count elevated causes move_pages() to fail on memory
    mapped files coming from xfs.
    
    Make iomap compatible with the migrate_page_move_mapping() assumption by
    elevating the page count as part of iomap_page_create() and lowering it
    in iomap_page_release().
    
    It causes the move_pages() syscall to misbehave on memory mapped files
    from xfs.  It does not not move any pages, which I suppose is "just" a
    perf issue, but it also ends up returning a positive number which is out
    of spec for the syscall.  Talking to Michal Hocko, it sounds like
    returning positive numbers might be a necessary update to move_pages()
    anyway though.
    
    Fixes: 82cb1417 ("xfs: add support for sub-pagesize writeback without buffer_heads")
    Signed-off-by: default avatarPiotr Jaroszynski <pjaroszynski@nvidia.com>
    [hch: actually get/put the page iomap_migrate_page() to make it work
          properly]
    Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    d23792f5
iomap.c 52.7 KB