• Arnd Bergmann's avatar
    [media] Input: atmel_mxt: disallow impossible configuration · 7a4b9a29
    Arnd Bergmann authored
    The newnly added debug mode for the atmel_mxt_ts driver relies on
    the v4l2 interface and vb2_vmalloc, but those might be configured
    as loadable modules when the driver itself is built-in, resulting
    in a link failure:
    
    drivers/input/touchscreen/atmel_mxt_ts.o: In function `mxt_vidioc_querycap':
    atmel_mxt_ts.c:(.text.mxt_vidioc_querycap+0x10): undefined reference to `video_devdata'
    drivers/input/touchscreen/atmel_mxt_ts.o: In function `mxt_buffer_queue':
    atmel_mxt_ts.c:(.text.mxt_buffer_queue+0x20): undefined reference to `vb2_plane_vaddr'
    atmel_mxt_ts.c:(.text.mxt_buffer_queue+0x164): undefined reference to `vb2_buffer_done'
    drivers/input/touchscreen/atmel_mxt_ts.o: In function `mxt_free_object_table':
    atmel_mxt_ts.c:(.text.mxt_free_object_table+0x18): undefined reference to `video_unregister_device'
    atmel_mxt_ts.c:(.text.mxt_free_object_table+0x20): undefined reference to `v4l2_device_unregister'
    
    The best workaround I could come up with is to disallow the debug
    mode unless it's actually possible to call it.
    
    Fixes: ecfdd7e2 ("[media] Input: atmel_mxt_ts - output diagnostic debug via V4L2 device")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarNick Dyer <nick@shmanahar.org>
    Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    7a4b9a29
Kconfig 32.8 KB