• Ingo Molnar's avatar
    [PATCH] lockdep: annotate ieee1394 skb-queue-head locking · d3788348
    Ingo Molnar authored
    ieee1394 reuses the skb infrastructure of the networking code, and uses two
    skb-head queues: ->pending_packet_queue and hpsbpkt_queue.  The latter is used
    in the usual fashion: processed from a kernel thread.  The other one,
    ->pending_packet_queue is also processed from hardirq context (f.e.  in
    hpsb_bus_reset()), which is not what the networking code usually does (which
    completes from softirq or process context).  This locking assymetry can be
    totally correct if done carefully, but it can also be dangerous if networking
    helper functions are reused, which could assume traditional networking use.
    
    It would probably be more robust to push this completion into a workqueue -
    but technically the code can be 100% correct, and lockdep has to be taught
    about it.  The solution is to split the ->pending_packet_queue skb-head->lock
    class from the networking lock-class by using a private lock-validator key.
    
    Has no effect on non-lockdep kernels.
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Cc: Jody McIntyre <scjody@modernduck.com>
    Cc: Ben Collins <bcollins@debian.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    d3788348
hosts.c 6.12 KB