• Paul Mackerras's avatar
    perf_counter: make it possible for hw_perf_counter_init to return error codes · d5d2bc0d
    Paul Mackerras authored
    Impact: better error reporting
    
    At present, if hw_perf_counter_init encounters an error, all it can do
    is return NULL, which causes sys_perf_counter_open to return an EINVAL
    error to userspace.  This isn't very informative for userspace; it means
    that userspace can't tell the difference between "sorry, oprofile is
    already using the PMU" and "we don't support this CPU" and "this CPU
    doesn't support the requested generic hardware event".
    
    This commit uses the PTR_ERR/ERR_PTR/IS_ERR set of macros to let
    hw_perf_counter_init return an error code on error rather than just NULL
    if it wishes.  If it does so, that error code will be returned from
    sys_perf_counter_open to userspace.  If it returns NULL, an EINVAL
    error will be returned to userspace, as before.
    
    This also adapts the powerpc hw_perf_counter_init to make use of this
    to return ENXIO, EINVAL, EBUSY, or EOPNOTSUPP as appropriate.  It would
    be good to add extra error numbers in future to allow userspace to
    distinguish the various errors that are currently reported as EINVAL,
    i.e. irq_period < 0, too many events in a group, conflict between
    exclude_* settings in a group, and PMU resource conflict in a group.
    
    [ v2: fix a bug pointed out by Corey Ashford where error returns from
          hw_perf_counter_init were not handled correctly in the case of
          raw hardware events.]
    Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
    Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    Orig-LKML-Reference: <20090330171023.682428180@chello.nl>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    d5d2bc0d
perf_counter.c 20.5 KB