• Phil Sutter's avatar
    net: ipv6: restrict hop_limit sysctl setting to range [1; 255] · d6df198d
    Phil Sutter authored
    Setting a value bigger than 255 resulted in using only the lower eight
    bits of that value as it is assigned to the u8 header field. To avoid
    this unexpected result, reject such values.
    
    Setting a value of zero is technically possible, but hosts receiving
    such a packet have to treat it like hop_limit was set to one, according
    to RFC2460. Therefore I don't see a use-case for that.
    
    Setting a route's hop_limit to zero in iproute2 means to use the sysctl
    default, which is not the case here: Setting e.g.
    net.conf.eth0.hop_limit=0 will not make the kernel use
    net.conf.all.hop_limit for outgoing packets on eth0. To avoid these
    kinds of confusion, reject zero.
    Signed-off-by: default avatarPhil Sutter <phil@nwl.cc>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d6df198d
addrconf.c 144 KB