• Tomas Winkler's avatar
    Staging: easycap: fix sparse warnings for module parameters · 2a9a05c4
    Tomas Winkler authored
    easycap_main.c:34:5: warning: symbol 'easycap_debug' was not declared. Should it be static?
    easycap_main.c:36:5: warning: symbol 'easycap_gain' was not declared. Should it be static?
    
    These two variables actually were declared in several places.
    The variables are used in several files.
    I've fixed "easycap_debug" so it gets declared in one place only and included properly.
    For "easycap_gain" made it static and I created added a
    ->gain member to the easycap struct.  This seems cleaner than using a
    global variable and later on we may make this controlable via sysfs.
    
    Cc:Mike Thomas <rmthomas@sciolus.org>
    Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
    Acked-by: default avatarDan Carpenter <error27@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    2a9a05c4
easycap_ioctl.h 1.51 KB