• Vincent Minet's avatar
    umh: fix memory leak on execve failure · db803036
    Vincent Minet authored
    If a UMH process created by fork_usermode_blob() fails to execute,
    a pair of struct file allocated by umh_pipe_setup() will leak.
    
    Under normal conditions, the caller (like bpfilter) needs to manage the
    lifetime of the UMH and its two pipes. But when fork_usermode_blob()
    fails, the caller doesn't really have a way to know what needs to be
    done. It seems better to do the cleanup ourselves in this case.
    
    Fixes: 449325b5 ("umh: introduce fork_usermode_blob() helper")
    Signed-off-by: default avatarVincent Minet <v.minet@criteo.com>
    Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    db803036
umh.c 19.2 KB