• Oleg Nesterov's avatar
    ptrace: mv send-SIGSTOP from do_fork() to ptrace_init_task() · dcace06c
    Oleg Nesterov authored
    If the new child is traced, do_fork() adds the pending SIGSTOP.
    It assumes that either it is traced because of auto-attach or the
    tracer attached later, in both cases sigaddset/set_thread_flag is
    correct even if SIGSTOP is already pending.
    
    Now that we have PTRACE_SEIZE this is no longer right in the latter
    case. If the tracer does PTRACE_SEIZE after copy_process() makes the
    child visible the queued SIGSTOP is wrong.
    
    We could check PT_SEIZED bit and change ptrace_attach() to set both
    PT_PTRACED and PT_SEIZED bits simultaneously but see the next patch,
    we need to know whether this child was auto-attached or not anyway.
    
    So this patch simply moves this code to ptrace_init_task(), this
    way we can never race with ptrace_attach().
    Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
    Acked-by: default avatarTejun Heo <tj@kernel.org>
    dcace06c
ptrace.h 14.1 KB