• Ian Campbell's avatar
    [ARM] 3032/1: sparse: complains about generic_fls() prototype in asm-arm/bitops.h · 7edc24c4
    Ian Campbell authored
    Patch from Ian Campbell
    
    Sparse complains about the definition of generic_fls in asm-arm/bitops.h:
      CHECK   /home/icampbell/devel/kernel/2.6/arch/arm/mach-pxa/viper.c
    include2/asm/bitops.h:350:34: error: marked inline, but without a definition
    
    The definition is unnecessary since linux/bitops.h defines generic_fls before including asm/bitops.h and asm/bitops.h should not be included directly. There are still some places where asm/bitops.h is directly included, but I think that code should be fixed. I was a little wary of the patch for this reason but lubbock, mainstone and assabet all build OK and so do my in house boards...
    
    ARM is the only arch with the generic_fls prototype in this way.
    Signed-off-by: default avatarIan Campbell <icampbell@arcom.com>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    7edc24c4
bitops.h 11.5 KB