• Bhaktipriya Shridhar's avatar
    [media] cx25821: Remove deprecated create_singlethread_workqueue · 072973ba
    Bhaktipriya Shridhar authored
    The workqueue "_irq_audio_queues" runs the audio upstream handler.
    It has a single work item(&dev->_audio_work_entry) and hence doesn't
    require ordering. Also, it is not being used on a memory reclaim path.
    Hence, the singlethreaded workqueue has been replaced with the use of
    system_wq.
    
    System workqueues have been able to handle high level of concurrency
    for a long time now and hence it's not required to have a singlethreaded
    workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
    created with create_singlethread_workqueue(), system_wq allows multiple
    work items to overlap executions even on the same CPU; however, a
    per-cpu workqueue doesn't have any CPU locality or global ordering
    guarantee unless the target CPU is explicitly specified and thus the
    increase of local concurrency shouldn't make any difference.
    
    The work item has been flushed in cx25821_stop_upstream_audio() to ensure
    that nothing is pending when the driver is disconnected.
    Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    072973ba
cx25821-audio-upstream.c 17.8 KB