• Vladimir Murzin's avatar
    KVM: arm: vgic: Fix compiler warnings when built for 32-bit · e533a37f
    Vladimir Murzin authored
    Well, this patch is looking ahead of time, but we'll get following
    compiler warnings as soon as we introduce vgic-v3 to 32-bit world
    
      CC      arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.o
    arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c: In function 'vgic_mmio_read_v3r_typer':
    arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:184:35: warning: left shift count >= width of type [-Wshift-count-overflow]
      value = (mpidr & GENMASK(23, 0)) << 32;
                                       ^
    In file included from ./include/linux/kernel.h:10:0,
                     from ./include/asm-generic/bug.h:13,
                     from ./arch/arm/include/asm/bug.h:59,
                     from ./include/linux/bug.h:4,
                     from ./include/linux/io.h:23,
                     from ./arch/arm/include/asm/arch_gicv3.h:23,
                     from ./include/linux/irqchip/arm-gic-v3.h:411,
                     from arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:14:
    arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c: In function 'vgic_v3_dispatch_sgi':
    ./include/linux/bitops.h:6:24: warning: left shift count >= width of type [-Wshift-count-overflow]
     #define BIT(nr)   (1UL << (nr))
                            ^
    arch/arm/kvm/../../../virt/kvm/arm/vgic/vgic-mmio-v3.c:614:20: note: in expansion of macro 'BIT'
      broadcast = reg & BIT(ICC_SGI1R_IRQ_ROUTING_MODE_BIT);
                        ^
    Let's fix them now.
    Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    Signed-off-by: default avatarVladimir Murzin <vladimir.murzin@arm.com>
    Signed-off-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
    e533a37f
vgic-mmio-v3.c 18.8 KB