• ravinandan.arakali@neterion.com's avatar
    [PATCH] S2io: Offline diagnostics fixes · ad4ebed0
    ravinandan.arakali@neterion.com authored
    This patch fixes the following bugs with offline diagnostics
    code(run with "ethtool -t").
    
    1. After running offline diagnostics, adapter would report
    corrupted packets on receive. This was because of adapter not
    being brought out of "RLDRAM test mode".
    2. Current EEPROM test works only for Xframe I. Since Xframe II
    uses different interface(SPI), support for this interface has
    been added. Also, since SPI supports write access to all areas
    of EEPROM, negative testing is done only for Xframe I.
    3. Return values from subfunctions of offline diagnostics have
    been corrected.
    4. In register test, expected value from rx_queue_cfg register
    is made to depend on adapter type.
    5. After the test, need to restore values at EEPROM offsets
    0x4F0 and 0x7F0. These locations were modified as part of test.
    6. Use macro SPECIAL_REG_WRITE for write access to mc_rldram_test_ctrl
    register. Also, couple of unnecessary writes to mc_rldram_test_ctrl
    have been removed.
    Signed-off-by: default avatarRavinandan Arakali <ravinandan.arakali@neterion.com>
    Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
    ad4ebed0
s2io-regs.h 27.2 KB