• Balbir Singh's avatar
    powerpc/pseries: Fix passing of pp0 in updatepp() and updateboltedpp() · e71ff982
    Balbir Singh authored
    Once upon a time there were only two PP (page protection) bits. In ISA
    2.03 an additional PP bit was added, but because of the layout of the
    HPTE it could not be made contiguous with the existing PP bits.
    
    The result is that we now have three PP bits, named pp0, pp1, pp2,
    where pp0 occupies bit 63 of dword 1 of the HPTE and pp1 and pp2
    occupy bits 1 and 0 respectively. Until recently Linux hasn't used
    pp0, however with the addition of _PAGE_KERNEL_RO we started using it.
    
    The problem arises in the LPAR code, where we need to translate the PP
    bits into the argument for the H_PROTECT hypercall. Currently the code
    only passes bits 0-2 of newpp, which covers pp1, pp2 and N (no
    execute), meaning pp0 is not passed to the hypervisor at all.
    
    We can't simply pass it through in bit 63, as that would collide with a
    different field in the flags argument, as defined in PAPR. Instead we
    have to shift it down to bit 8 (IBM bit 55).
    
    Fixes: e58e87ad ("powerpc/mm: Update _PAGE_KERNEL_RO")
    Cc: stable@vger.kernel.org # v4.7+
    Signed-off-by: default avatarBalbir Singh <bsingharora@gmail.com>
    [mpe: Simplify the test, rework change log]
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    e71ff982
lpar.c 25.5 KB