• Jarod Wilson's avatar
    net/core: ensure features get disabled on new lower devs · e7868a85
    Jarod Wilson authored
    With moving netdev_sync_lower_features() after the .ndo_set_features
    calls, I neglected to verify that devices added *after* a flag had been
    disabled on an upper device were properly added with that flag disabled as
    well. This currently happens, because we exit __netdev_update_features()
    when we see dev->features == features for the upper dev. We can retain the
    optimization of leaving without calling .ndo_set_features with a bit of
    tweaking and a goto here.
    
    Fixes: fd867d51 ("net/core: generic support for disabling netdev features down stack")
    CC: "David S. Miller" <davem@davemloft.net>
    CC: Eric Dumazet <edumazet@google.com>
    CC: Jay Vosburgh <j.vosburgh@gmail.com>
    CC: Veaceslav Falico <vfalico@gmail.com>
    CC: Andy Gospodarek <gospo@cumulusnetworks.com>
    CC: Jiri Pirko <jiri@resnulli.us>
    CC: Nikolay Aleksandrov <razor@blackwall.org>
    CC: Michal Kubecek <mkubecek@suse.cz>
    CC: Alexander Duyck <alexander.duyck@gmail.com>
    CC: netdev@vger.kernel.org
    Reported-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
    Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    e7868a85
dev.c 194 KB