• Zhang Yanmin's avatar
    SLUB: Fix default slab order for big object sizes · e8120ff1
    Zhang Yanmin authored
    The default order of kmalloc-8192 on 2*4 stoakley is an issue of
    calculate_order.
    
    slab_size       order           name
    -------------------------------------------------
    4096            3               sgpool-128
    8192            2               kmalloc-8192
    16384           3               kmalloc-16384
    
    kmalloc-8192's default order is smaller than sgpool-128's.
    
    On 4*4 tigerton machine, a similiar issue appears on another kmem_cache.
    
    Function calculate_order uses 'min_objects /= 2;' to shrink. Plus size
    calculation/checking in slab_order, sometimes above issue appear.
    
    Below patch against 2.6.29-rc2 fixes it.
    
    I checked the default orders of all kmem_cache and they don't become
    smaller than before. So the patch wouldn't hurt performance.
    
    Signed-off-by Zhang Yanmin <yanmin.zhang@linux.intel.com>
    Signed-off-by: default avatarPekka Enberg <penberg@cs.helsinki.fi>
    e8120ff1
slub.c 106 KB