• Paul Gortmaker's avatar
    drivers/staging: make android tegra_ion.c properly tristate · 35890c28
    Paul Gortmaker authored
    The Kconfig currently controlling compilation of this code is:
    
    drivers/staging/android/ion/Kconfig:config ION_TEGRA
    drivers/staging/android/ion/Kconfig:    tristate "Ion for Tegra"
    
    ...which led me to incorrectly conclude this file was built modular
    earlier.  However the above CONFIG is just used to enter the dir and
    once we do enter that dir, we see the build is unconditional:
    
    drivers/staging/android/ion/Makefile:obj-$(CONFIG_ION_TEGRA) += tegra/
    drivers/staging/android/ion/tegra/Makefile:obj-y += tegra_ion.o
    
    ...meaning that it currently is not being built as a module by anyone.
    
    However, given that the Kconfig did explicitly choose tristate, and that
    the dummy ion driver is (functionally) tristate, I chose to make the
    Makefile do the right thing for it to build as a module.
    
    After this change, on an ARM allmodconfig, we see:
    
      CC [M]  drivers/staging/android/ion/tegra/tegra_ion.o
    
    so it does build OK as a module.  I can't vouch for the modular
    functionality however, so consider this compile tested only.
    
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: "Arve Hjønnevåg" <arve@android.com>
    Cc: Riley Andrews <riandrews@android.com>
    Cc: Stephen Warren <swarren@wwwdotorg.org>
    Cc: Thierry Reding <thierry.reding@gmail.com>
    Cc: Alexandre Courbot <gnurou@gmail.com>
    Cc: Markus Elfring <elfring@users.sourceforge.net>
    Cc: devel@driverdev.osuosl.org
    Cc: linux-tegra@vger.kernel.org
    Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    35890c28
Makefile 39 Bytes