• Yonghong Song's avatar
    tools/bpf: add const qualifier to btf__get_map_kv_tids() map_name parameter · a6c109a6
    Yonghong Song authored
    Commit 96408c43 ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
    added the API function btf__get_map_kv_tids():
      btf__get_map_kv_tids(const struct btf *btf, char *map_name, ...)
    
    The parameter map_name has type "char *". This is okay inside libbpf library since
    the map_name is from bpf_map->name which also has type "char *".
    
    This will be problematic if the caller for map_name already has attribute "const",
    e.g., from C++ string.c_str(). It will result in either a warning or an error.
    
      /home/yhs/work/bcc/src/cc/btf.cc:166:51:
        error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]
          return btf__get_map_kv_tids(btf_, map_name.c_str()
    
    This patch added "const" attributes to map_name parameter.
    
    Fixes: 96408c43 ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Acked-by: default avatarAlexei Starovoitov <ast@kernel.org>
    Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    a6c109a6
btf.h 3.25 KB