• Arnaldo Carvalho de Melo's avatar
    perf parse-events: Use asprintf() instead of strncpy() to read tracepoint files · 7125f204
    Arnaldo Carvalho de Melo authored
    Make the code more compact by using asprintf() instead of malloc()+strncpy() which also uses
    less memory and avoids these warnings with gcc 10:
    
        CC       /tmp/build/perf/util/cloexec.o
      In file included from /usr/include/string.h:495,
                       from util/parse-events.h:12,
                       from util/parse-events.c:18:
      In function ‘strncpy’,
          inlined from ‘tracepoint_id_to_path’ at util/parse-events.c:271:5:
      /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ offset [275, 511] from the object at ‘sys_dirent’ is out of the bounds of referenced subobject ‘d_name’ with type ‘char[256]’ at offset 19 [-Werror=array-bounds]
        106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
            |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from /usr/include/dirent.h:61,
                       from util/parse-events.c:5:
      util/parse-events.c: In function ‘tracepoint_id_to_path’:
      /usr/include/bits/dirent.h:33:10: note: subobject ‘d_name’ declared here
         33 |     char d_name[256];  /* We must not include limits.h! */
            |          ^~~~~~
      In file included from /usr/include/string.h:495,
                       from util/parse-events.h:12,
                       from util/parse-events.c:18:
      In function ‘strncpy’,
          inlined from ‘tracepoint_id_to_path’ at util/parse-events.c:273:5:
      /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ offset [275, 511] from the object at ‘evt_dirent’ is out of the bounds of referenced subobject ‘d_name’ with type ‘char[256]’ at offset 19 [-Werror=array-bounds]
        106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
            |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from /usr/include/dirent.h:61,
                       from util/parse-events.c:5:
      util/parse-events.c: In function ‘tracepoint_id_to_path’:
      /usr/include/bits/dirent.h:33:10: note: subobject ‘d_name’ declared here
         33 |     char d_name[256];  /* We must not include limits.h! */
            |          ^~~~~~
        CC       /tmp/build/perf/util/call-path.o
    
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: http://lore.kernel.org/lkml/20200302145535.GA28183@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    7125f204
parse-events.c 71.4 KB