• Brendan Jackman's avatar
    sched/fair: Sync task util before slow-path wakeup · ea16f0ea
    Brendan Jackman authored
    We use task_util() in find_idlest_group() via capacity_spare_wake().
    This task_util() updated in wake_cap(). However wake_cap() is not the
    only reason for ending up in find_idlest_group() - we could have been sent
    there by wake_wide(). So explicitly sync the task util with prev_cpu
    when we are about to head to find_idlest_group().
    
    We could simply do this at the beginning of
    select_task_rq_fair() (i.e. irrespective of whether we're heading to
    select_idle_sibling() or find_idlest_group() & co), but I didn't want to
    slow down the select_idle_sibling() path more than necessary.
    
    Don't do this during fork balancing, we won't need the task_util and
    we'd just clobber the last_update_time, which is supposed to be 0.
    Signed-off-by: default avatarBrendan Jackman <brendan.jackman@arm.com>
    Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
    Cc: Andres Oportus <andresoportus@google.com>
    Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
    Cc: Joel Fernandes <joelaf@google.com>
    Cc: Josef Bacik <josef@toxicpanda.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Morten Rasmussen <morten.rasmussen@arm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Vincent Guittot <vincent.guittot@linaro.org>
    Link: http://lkml.kernel.org/r/20170808095519.10077-1-brendan.jackman@arm.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    ea16f0ea
fair.c 258 KB