• Stephen Warren's avatar
    ARM: tegra: rely on bootloader pinmux programming on Tegra124 · 6dbaff2b
    Stephen Warren authored
    The defined mechanism for programming the Tegra pinmux is to perform all
    of the following at once in order, before using any I/O controller that
    is affected by the pinmux:
    
    - Set the CLAMP_INPUTS_WHEN_TRISTATED PMC register bit.
    - Set up any GPIO pins to their "initial" state.
    - Program all pinmux settings in one go.
    
    Other methods such as:
    
    - Not setting CLAMP_INPUTS_WHEN_TRISTATED.
    - Not setting GPIOs to their "initial" state before programming the
      pinmux settings of the related pin, in particular the mux function.
    - Not programming the entire pinmux at once, in order to avoid
      possible conflicting settings.
    
    ... are not qualified or supported by NVIDIA ASIC/syseng. They could
    cause glitches or undesired output levels on some pins, or controller
    malfunction.
    
    While we've been getting away with doing something different on many
    Tegra boards without issue, I believe we've just been getting lucky.
    I'd like to switch all Tegra124 systems to the correct scheme now so
    they provide the right example to follow, and require that any new
    boards we support upstream work in the same fashion.
    
    While it would be nice to update boards containing older SoCs for
    consistency, I don't anticipate doing so. It's too much churn to change
    at this time. At least with all Tegra124 boards converted, the most
    recent boards provide the correct example.
    
    Since the bootloader needs to reprogram the pinmux to access certain
    peripherals, it must program the entire pinmux due to the supported
    rules above. As such, there is no need to program any part of the pinmux
    from the kernel, unless dynamic pinmuxing is used. Given this, we couuld
    simply remove the pinmux "default" state from the DT entirely. However,
    some bootloaders parse the DT to perform their initial pinmux setup, so
    it's useful to keep the pinmux data in DT. To allow this while avoiding
    redundant work in the kernel, rename the "default" state to "boot". The
    kernel won't apply this, but bootloaders can still look for this state
    name and apply it. Note however that the DT provides zero information
    about the required initial GPIO setup, so bootloaders using this approach
    are not likely to operate correctly without an additional GPIO
    initialization table somewhere. Previous discussions on the DT mailing
    list have rejected adding such a table to DT...
    
    The following U-Boot commits fully initialize the pinmux:
    
    Jetson TK1: 4ff213b8e478 ARM: tegra: clamp inputs on Jetson TK1
    Venice2: 3365479ce78a ARM: tegra: Venice2 pinmux spreadsheet updates
    Both are part of U-Boot v2014.07 and later.
    
    Without those commits, the only fallout I see from this change is that
    HDMI on Venice2 no longer works. Given the very small user-base of this
    platform, I feel that requiring a bootloader update is reasonable.
    Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
    6dbaff2b
tegra124-venice2.dts 29.8 KB