• Jan Kara's avatar
    xfs: Keep sb_bad_features2 consistent with sb_features2 · 1a43ec03
    Jan Kara authored
    Currently when we modify sb_features2, we store the same value also in
    sb_bad_features2. However in most places we forget to mark field
    sb_bad_features2 for logging and thus it can happen that a change to it
    is lost. This results in an inconsistent sb_features2 and
    sb_bad_features2 fields e.g. after xfstests test xfs/187.
    
    Fix the problem by changing XFS_SB_FEATURES2 to actually mean both
    sb_features2 and sb_bad_features2 fields since this is always what we
    want to log. This isn't ideal because the fact that XFS_SB_FEATURES2
    means two fields could cause some problem in future however the code is
    hopefully less error prone that it is now.
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    1a43ec03
xfs_mount.c 51.3 KB