• Julia Lawall's avatar
    i2c-dev: Use memdup_user · f1c2e33c
    Julia Lawall authored
    Use memdup_user when user data is immediately copied into the allocated
    region.  Note that in the second case, the ++i is no longer necessary, as
    the last value is already freed if needed by the call to memdup_user.
    
    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @@
    expression from,to,size,flag;
    position p;
    identifier l1,l2;
    @@
    
    -  to = \(kmalloc@p\|kzalloc@p\)(size,flag);
    +  to = memdup_user(from,size);
       if (
    -      to==NULL
    +      IS_ERR(to)
                     || ...) {
       <+... when != goto l1;
    -  -ENOMEM
    +  PTR_ERR(to)
       ...+>
       }
    -  if (copy_from_user(to, from, size) != 0) {
    -    <+... when != goto l2;
    -    -EFAULT
    -    ...+>
    -  }
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    f1c2e33c
i2c-dev.c 16.3 KB