• Sven Van Asbroeck's avatar
    rtc: 88pm860x: prevent use-after-free on device remove · f22b1ba1
    Sven Van Asbroeck authored
    The device's remove() attempts to shut down the delayed_work scheduled
    on the kernel-global workqueue by calling flush_scheduled_work().
    
    Unfortunately, flush_scheduled_work() does not prevent the delayed_work
    from re-scheduling itself. The delayed_work might run after the device
    has been removed, and touch the already de-allocated info structure.
    This is a potential use-after-free.
    
    Fix by calling cancel_delayed_work_sync() during remove(): this ensures
    that the delayed work is properly cancelled, is no longer running, and
    is not able to re-schedule itself.
    
    This issue was detected with the help of Coccinelle.
    Signed-off-by: default avatarSven Van Asbroeck <TheSven73@gmail.com>
    Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
    f22b1ba1
rtc-88pm860x.c 12.7 KB