• Srivatsa S. Bhat's avatar
    powerpc/pseries: Always enable CONFIG_HOTPLUG_CPU on PSERIES SMP · f274ef87
    Srivatsa S. Bhat authored
    Adam Lackorzynski reported the following build failure on
    !CONFIG_HOTPLUG_CPU configuration:
    
      CC      arch/powerpc/kernel/rtas.o
    arch/powerpc/kernel/rtas.c: In function ‘rtas_cpu_state_change_mask’:
    arch/powerpc/kernel/rtas.c:843:4: error: implicit declaration of function ‘cpu_down’ [-Werror=implicit-function-declaration]
    cc1: all warnings being treated as errors
    make[1]: *** [arch/powerpc/kernel/rtas.o] Error 1
    make: *** [arch/powerpc/kernel] Error 2
    
    The build fails because cpu_down() is defined only under CONFIG_HOTPLUG_CPU.
    
    Looking further, the mobility code in pseries is one of the call-sites which
    uses rtas_ibm_suspend_me(), which in turn calls rtas_cpu_state_change_mask().
    And the mobility code is unconditionally compiled-in (it does not fall under
    any Kconfig option). And commit 120496ac (powerpc: Bring all threads online
    prior to migration/hibernation) which introduced this build regression is
    critical for the proper functioning of the migration code. So it appears
    that the only solution to this problem is to enable CONFIG_HOTPLUG_CPU if
    SMP is enabled on PPC_PSERIES platforms. So make that change in the Kconfig.
    Reported-by: default avatarAdam Lackorzynski <adam@os.inf.tu-dresden.de>
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    f274ef87
Kconfig 4.04 KB