• Linus Torvalds's avatar
    Revert "rtc: Expire alarms after the time is set." · f423fc62
    Linus Torvalds authored
    This reverts commit 93b2ec01.
    
    The call to "schedule_work()" in rtc_initialize_alarm() happens too
    early, and can cause oopses at bootup
    
    Neil Brown explains why we do it:
    
      "If you set an alarm in the future, then shutdown and boot again after
       that time, then you will end up with a timer_queue node which is in
       the past.
    
       When this happens the queue gets stuck.  That entry-in-the-past won't
       get removed until and interrupt happens and an interrupt won't happen
       because the RTC only triggers an interrupt when the alarm is "now".
    
       So you'll find that e.g.  "hwclock" will always tell you that
       'select' timed out.
    
       So we force the interrupt work to happen at the start just in case."
    
    and has a patch that convert it to do things in-process rather than with
    the worker thread, but right now it's too late to play around with this,
    so we just revert the patch that caused problems for now.
    Reported-by: default avatarSander Eikelenboom <linux@eikelenboom.it>
    Requested-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Requested-by: default avatarJohn Stultz <john.stultz@linaro.org>
    Cc: Neil Brown <neilb@suse.de>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f423fc62
interface.c 22.5 KB