• Paul Mundt's avatar
    video: sm501fb: Early initialization of mm_lock mutex. · f50bf2b2
    Paul Mundt authored
    Commit 537a1bf0 (fbdev: add mutex for
    fb_mmap locking) introduces a ->mm_lock mutex for protecting smem
    assignments. Unfortunately in the case of sm501fb these happen quite
    early in the initialization code, well before the mutex_init() that takes
    place in register_framebuffer(), leading to:
    
       Badness at kernel/mutex.c:207
    
       Pid : 1, Comm:          swapper
       CPU : 0                 Not tainted  (2.6.31-rc1-00284-g529ba0d9-dirty #2273)
    
       PC is at __mutex_lock_slowpath+0x72/0x1bc
       PR is at __mutex_lock_slowpath+0x66/0x1bc
       ...
    
    matroxfb appears to have the same issue and has solved it with an early
    mutex_init(), so we do the same for sm501fb.
    Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
    Cc: Krzysztof Helt <krzysztof.h1@wp.pl>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    f50bf2b2
sm501fb.c 45 KB