• Paul Mackerras's avatar
    [PATCH] Obvious bugfix for yenta resource allocation · f7d1d23c
    Paul Mackerras authored
    Recent changes (well, dating from 12 July) have broken cardbus on my
    powerbook: I get 3 messages saying "no resource of type xxx available,
    trying to continue", and if I plug in my wireless card, it complains
    that there are no resources allocated to the card.  This all worked in
    2.6.12.
    
    Looking at the code in yenta_socket.c, function yenta_allocate_res,
    it's obvious what is wrong: if we get to line 639 (i.e. there wasn't a
    usable preassigned resource), we will always flow through to line 668,
    which is the printk that I was seeing, even if a resource was
    successfully allocated.  It looks to me as though there should be a
    return statement after the two config_writel's in each of the 3
    branches of the if statements, so that the function returns after
    successfully setting up the resource.
    
    The patch below adds these return statements, and with this patch,
    cardbus works on my powerbook once again.
    Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
    Acked-by: default avatarDominik Brodowski <linux@dominikbrodowski.net>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    f7d1d23c
yenta_socket.c 33.8 KB