• Stephen Boyd's avatar
    msm_serial: Fix sparse warnings · f8fb952f
    Stephen Boyd authored
    drivers/tty/serial/msm_serial.c:302:6: warning: symbol 'msm_set_mctrl' was
    not declared. Should it be static?
    drivers/tty/serial/msm_serial.c:597:17: warning: incorrect type in argument 2
    (different address spaces)
    drivers/tty/serial/msm_serial.c:597:17: expected void volatile [noderef] <asn:2>*addr
    drivers/tty/serial/msm_serial.c:597:17: got unsigned int *
    drivers/tty/serial/msm_serial.c:608:33: warning: incorrect type in argument 1
    (different address spaces)
    drivers/tty/serial/msm_serial.c:608:33: expected void volatile [noderef] <asn:2>*addr
    drivers/tty/serial/msm_serial.c:608:33: got unsigned int *gsbi_base
    drivers/tty/serial/msm_serial.c:648:37: warning: incorrect type in assignment
    (different address spaces)
    drivers/tty/serial/msm_serial.c:648:37: expected unsigned int *gsbi_base
    drivers/tty/serial/msm_serial.c:648:37: got void [noderef] <asn:2>*
    
    Mark the ioremapped memory as __iomem and use writel instead of
    iowrite because we're not dealing with PCI devices. Also, mark
    msm_set_mctrl() static because it isn't used outside this file.
    Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
    Acked-by: default avatarDavid Brown <davidb@codeaurora.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    f8fb952f
msm_serial.c 22.6 KB