• Jani Nikula's avatar
    drm/i915/dsi: fix bxt split screen and color issue · f90e8c36
    Jani Nikula authored
    Fix the failure mode where the display appears split, or shifted about
    2/3 of the screen, and the color components are cycled. Turns out we
    were missing the crucial BXT_DEFEATURE_DPI_FIFO_CTR bit in the
    EOT_DISABLE register.
    
    Per bspec, with the bit set, the "mipi_dpf_vblank_start" signal is
    asserted only when the complete frame is transferred in the DPHY line
    and also the DPI FIFO is flushed out at the end of each frame.
    
    The problem was mitigated by keeping the panel fitter enabled, but that
    only limited the issue to a shift of about 0..10 pixels. With the fix
    here, the panel fitter workaround does not seem to be needed at all.
    
    While at it, set BXT_DPHY_DEFEATURE_EN in EOT_DISABLE register which is
    also needed per the BXT DSI mode set sequence.
    
    Issue: VIZ-7610
    Cc: Mika Kahola <mika.kahola@intel.com>
    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
    Cc: Ramalingam C <ramalingam.c@intel.com>
    Cc: Uma Shankar <uma.shankar@intel.com>
    Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
    Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1464965825-31035-1-git-send-email-jani.nikula@intel.com
    f90e8c36
i915_reg.h 327 KB