• Stefan Raspl's avatar
    blktrace: remove debugfs entries on bad path · fd51d251
    Stefan Raspl authored
    debugfs directory entries for devices are not removed on some
    of the failure pathes in do_blk_trace_setup().
    One way to reproduce is to start blktrace on multiple devices
    with insufficient Vmalloc space: Devices will fail with
    a message like this:
    
    	BLKTRACESETUP(2) /dev/sdu failed: 5/Input/output error
    
    If so, the respective entries in debugfs
    (e.g. /sys/kernel/debug/block/sdu) will remain and subsequent
    attempts to start blktrace on the respective devices will not
    succeed due to existing directories.
    
    [ Impact: fix /debug/tracing file cleanup corner case ]
    Signed-off-by: default avatarStefan Raspl <stefan.raspl@linux.vnet.ibm.com>
    Acked-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
    Cc: Li Zefan <lizf@cn.fujitsu.com>
    Cc: schwidefsky@de.ibm.com
    Cc: heiko.carstens@de.ibm.com
    LKML-Reference: <4A1266CC.5040801@linux.vnet.ibm.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    fd51d251
blktrace.c 38.6 KB