Commit 005161c8 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Dmitry Torokhov

Input: spaceball - mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114767
Addresses-Coverity-ID: 114768
Addresses-Coverity-ID: 114769
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 781f2dd0
...@@ -162,6 +162,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio, ...@@ -162,6 +162,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio,
break; break;
} }
spaceball->escape = 0; spaceball->escape = 0;
/* fall through */
case 'M': case 'M':
case 'Q': case 'Q':
case 'S': case 'S':
...@@ -169,6 +170,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio, ...@@ -169,6 +170,7 @@ static irqreturn_t spaceball_interrupt(struct serio *serio,
spaceball->escape = 0; spaceball->escape = 0;
data &= 0x1f; data &= 0x1f;
} }
/* fall through */
default: default:
if (spaceball->escape) if (spaceball->escape)
spaceball->escape = 0; spaceball->escape = 0;
...@@ -234,11 +236,13 @@ static int spaceball_connect(struct serio *serio, struct serio_driver *drv) ...@@ -234,11 +236,13 @@ static int spaceball_connect(struct serio *serio, struct serio_driver *drv)
input_dev->keybit[BIT_WORD(BTN_A)] |= BIT_MASK(BTN_A) | input_dev->keybit[BIT_WORD(BTN_A)] |= BIT_MASK(BTN_A) |
BIT_MASK(BTN_B) | BIT_MASK(BTN_C) | BIT_MASK(BTN_B) | BIT_MASK(BTN_C) |
BIT_MASK(BTN_MODE); BIT_MASK(BTN_MODE);
/* fall through */
default: default:
input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_2) | input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_2) |
BIT_MASK(BTN_3) | BIT_MASK(BTN_4) | BIT_MASK(BTN_3) | BIT_MASK(BTN_4) |
BIT_MASK(BTN_5) | BIT_MASK(BTN_6) | BIT_MASK(BTN_5) | BIT_MASK(BTN_6) |
BIT_MASK(BTN_7) | BIT_MASK(BTN_8); BIT_MASK(BTN_7) | BIT_MASK(BTN_8);
/* fall through */
case SPACEBALL_3003C: case SPACEBALL_3003C:
input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_1) | input_dev->keybit[BIT_WORD(BTN_0)] |= BIT_MASK(BTN_1) |
BIT_MASK(BTN_8); BIT_MASK(BTN_8);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment