Commit 00a79722 authored by Tvrtko Ursulin's avatar Tvrtko Ursulin

drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

In commit 0426c046 ("drm/i915/pmu: Only allow running on a single
CPU") I attempted to clarify the CPU hotplug logic in our PMU
implementation, but missed that a more logical error to return, when
attempting to initialize an event on a currently inactive CPU, is -EINVAL
rather than -ENODEV.

This is because i915 PMU explicitly disallows running counters on more
than one CPU at a time, and is not reporting that the requested CPU does
not exist, or is off-line.
Signed-off-by: default avatarTvrtko Ursulin <tvrtko.ursulin@intel.com>
Reported-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20171128105515.21998-1-tvrtko.ursulin@linux.intel.com
parent 448aa911
...@@ -338,7 +338,7 @@ static int i915_pmu_event_init(struct perf_event *event) ...@@ -338,7 +338,7 @@ static int i915_pmu_event_init(struct perf_event *event)
/* only allow running on one cpu at a time */ /* only allow running on one cpu at a time */
if (!cpumask_test_cpu(event->cpu, &i915_pmu_cpumask)) if (!cpumask_test_cpu(event->cpu, &i915_pmu_cpumask))
return -ENODEV; return -EINVAL;
if (is_engine_event(event)) { if (is_engine_event(event)) {
ret = engine_event_init(event); ret = engine_event_init(event);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment