Commit 01b3cdfc authored by Johan Hovold's avatar Johan Hovold

USB: serial: keyspan_pda: fix modem-status error handling

Fix broken modem-status error handling which could lead to bits of slab
data leaking to user space.

Fixes: 3b36a8fd ("usb: fix uninitialized variable warning in keyspan_pda")
Cc: stable <stable@vger.kernel.org>     # 2.6.27
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 367b160f
...@@ -369,8 +369,10 @@ static int keyspan_pda_get_modem_info(struct usb_serial *serial, ...@@ -369,8 +369,10 @@ static int keyspan_pda_get_modem_info(struct usb_serial *serial,
3, /* get pins */ 3, /* get pins */
USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_IN, USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_IN,
0, 0, data, 1, 2000); 0, 0, data, 1, 2000);
if (rc >= 0) if (rc == 1)
*value = *data; *value = *data;
else if (rc >= 0)
rc = -EIO;
kfree(data); kfree(data);
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment