Commit 01e537f7 authored by Kuppuswamy Sathyanarayanan's avatar Kuppuswamy Sathyanarayanan Committed by Jonathan Cameron

iio: ltr501: Fix proximity threshold boundary check

Currently, proximity sensor boundary check is done
inside the switch block but outside the case
statement.Since this code will never get executed,
moved the check outside the switch case statement.

   867          case IIO_PROXIMITY:
   868                  switch (dir) {
   // Following line has been moved outside the switch block.
   869                  if (val > LTR501_PS_THRESH_MASK)
   870                          return -EINVAL;
   871                  case IIO_EV_DIR_RISING:
Signed-off-by: default avatarKuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent f2c714a0
...@@ -865,9 +865,9 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev, ...@@ -865,9 +865,9 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,
return -EINVAL; return -EINVAL;
} }
case IIO_PROXIMITY: case IIO_PROXIMITY:
switch (dir) {
if (val > LTR501_PS_THRESH_MASK) if (val > LTR501_PS_THRESH_MASK)
return -EINVAL; return -EINVAL;
switch (dir) {
case IIO_EV_DIR_RISING: case IIO_EV_DIR_RISING:
mutex_lock(&data->lock_ps); mutex_lock(&data->lock_ps);
ret = regmap_bulk_write(data->regmap, ret = regmap_bulk_write(data->regmap,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment