Commit 022205ff authored by Brandon Syu's avatar Brandon Syu Committed by Alex Deucher

drm/amd/display: fix rotation_angle to use enum values

[Why]
Hardcoded fixed values are not proper.

[How]
Use enum values instead of fixed numbers.
Signed-off-by: default avatarBrandon Syu <Brandon.Syu@amd.com>
Reviewed-by: default avatarEric Yang <eric.yang2@amd.com>
Acked-by: default avatarBhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2c61704b
...@@ -261,28 +261,28 @@ static void hubp21_apply_PLAT_54186_wa( ...@@ -261,28 +261,28 @@ static void hubp21_apply_PLAT_54186_wa(
address->video_progressive.luma_addr.high_part == 0xf4) address->video_progressive.luma_addr.high_part == 0xf4)
return; return;
if ((rotation_angle == 0 || rotation_angle == 180) if ((rotation_angle == ROTATION_ANGLE_0 || rotation_angle == ROTATION_ANGLE_180)
&& viewport_c_height <= 512) && viewport_c_height <= 512)
return; return;
if ((rotation_angle == 90 || rotation_angle == 270) if ((rotation_angle == ROTATION_ANGLE_90 || rotation_angle == ROTATION_ANGLE_270)
&& viewport_c_width <= 512) && viewport_c_width <= 512)
return; return;
switch (rotation_angle) { switch (rotation_angle) {
case 0: /* 0 degree rotation */ case ROTATION_ANGLE_0: /* 0 degree rotation */
row_height = 128; row_height = 128;
patched_viewport_height = (viewport_c_height / row_height + 1) * row_height + 1; patched_viewport_height = (viewport_c_height / row_height + 1) * row_height + 1;
patched_viewport_width = viewport_c_width; patched_viewport_width = viewport_c_width;
hubp21->PLAT_54186_wa_chroma_addr_offset = 0; hubp21->PLAT_54186_wa_chroma_addr_offset = 0;
break; break;
case 2: /* 180 degree rotation */ case ROTATION_ANGLE_180: /* 180 degree rotation */
row_height = 128; row_height = 128;
patched_viewport_height = viewport_c_height + row_height; patched_viewport_height = viewport_c_height + row_height;
patched_viewport_width = viewport_c_width; patched_viewport_width = viewport_c_width;
hubp21->PLAT_54186_wa_chroma_addr_offset = 0 - chroma_pitch * row_height * chroma_bpe; hubp21->PLAT_54186_wa_chroma_addr_offset = 0 - chroma_pitch * row_height * chroma_bpe;
break; break;
case 1: /* 90 degree rotation */ case ROTATION_ANGLE_90: /* 90 degree rotation */
row_height = 256; row_height = 256;
if (h_mirror_en) { if (h_mirror_en) {
patched_viewport_height = viewport_c_height; patched_viewport_height = viewport_c_height;
...@@ -294,7 +294,7 @@ static void hubp21_apply_PLAT_54186_wa( ...@@ -294,7 +294,7 @@ static void hubp21_apply_PLAT_54186_wa(
hubp21->PLAT_54186_wa_chroma_addr_offset = 0 - tile_blk_size; hubp21->PLAT_54186_wa_chroma_addr_offset = 0 - tile_blk_size;
} }
break; break;
case 3: /* 270 degree rotation */ case ROTATION_ANGLE_270: /* 270 degree rotation */
row_height = 256; row_height = 256;
if (h_mirror_en) { if (h_mirror_en) {
patched_viewport_height = viewport_c_height; patched_viewport_height = viewport_c_height;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment