Commit 02e02048 authored by Nicholas Sim's avatar Nicholas Sim Committed by Greg Kroah-Hartman

staging: wlan-ng: rewrite NULL comparison

It is not necessary to compare explicitly to NULL. Rewrite if condition
as (!dev) or (dev) as suggested in Documentation/CodingStyle
Signed-off-by: default avatarNicholas Sim <nicholassimws@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9f563f1a
...@@ -614,7 +614,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void) ...@@ -614,7 +614,7 @@ static hfa384x_usbctlx_t *usbctlx_alloc(void)
ctlx = kzalloc(sizeof(*ctlx), ctlx = kzalloc(sizeof(*ctlx),
in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
if (ctlx != NULL) if (ctlx)
init_completion(&ctlx->done); init_completion(&ctlx->done);
return ctlx; return ctlx;
...@@ -797,7 +797,7 @@ static inline struct usbctlx_completor *init_rmem_completor( ...@@ -797,7 +797,7 @@ static inline struct usbctlx_completor *init_rmem_completor(
----------------------------------------------------------------*/ ----------------------------------------------------------------*/
static void hfa384x_cb_status(hfa384x_t *hw, const hfa384x_usbctlx_t *ctlx) static void hfa384x_cb_status(hfa384x_t *hw, const hfa384x_usbctlx_t *ctlx)
{ {
if (ctlx->usercb != NULL) { if (ctlx->usercb) {
hfa384x_cmdresult_t cmdresult; hfa384x_cmdresult_t cmdresult;
if (ctlx->state != CTLX_COMPLETE) { if (ctlx->state != CTLX_COMPLETE) {
...@@ -2738,7 +2738,7 @@ static void hfa384x_usbctlx_completion_task(unsigned long data) ...@@ -2738,7 +2738,7 @@ static void hfa384x_usbctlx_completion_task(unsigned long data)
/* Call the completion function that this /* Call the completion function that this
* command was assigned, assuming it has one. * command was assigned, assuming it has one.
*/ */
if (ctlx->cmdcb != NULL) { if (ctlx->cmdcb) {
spin_unlock_irqrestore(&hw->ctlxq.lock, flags); spin_unlock_irqrestore(&hw->ctlxq.lock, flags);
ctlx->cmdcb(hw, ctlx); ctlx->cmdcb(hw, ctlx);
spin_lock_irqsave(&hw->ctlxq.lock, flags); spin_lock_irqsave(&hw->ctlxq.lock, flags);
...@@ -3629,7 +3629,7 @@ static void hfa384x_ctlxout_callback(struct urb *urb) ...@@ -3629,7 +3629,7 @@ static void hfa384x_ctlxout_callback(struct urb *urb)
dbprint_urb(urb); dbprint_urb(urb);
#endif #endif
if ((urb->status == -ESHUTDOWN) || if ((urb->status == -ESHUTDOWN) ||
(urb->status == -ENODEV) || (hw == NULL)) (urb->status == -ENODEV) || !hw)
return; return;
retry: retry:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment