Commit 03d9a9fe authored by Roberto Bergantinos Corpas's avatar Roberto Bergantinos Corpas Committed by Steve French

CIFS: avoid using MID 0xFFFF

According to MS-CIFS specification MID 0xFFFF should not be used by the
CIFS client, but we actually do. Besides, this has proven to cause races
leading to oops between SendReceive2/cifs_demultiplex_thread. On SMB1,
MID is a 2 byte value easy to reach in CurrentMid which may conflict with
an oplock break notification request coming from server
Signed-off-by: default avatarRoberto Bergantinos Corpas <rbergant@redhat.com>
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
Reviewed-by: default avatarAurelien Aptel <aaptel@suse.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
parent 553292a6
...@@ -171,6 +171,9 @@ cifs_get_next_mid(struct TCP_Server_Info *server) ...@@ -171,6 +171,9 @@ cifs_get_next_mid(struct TCP_Server_Info *server)
/* we do not want to loop forever */ /* we do not want to loop forever */
last_mid = cur_mid; last_mid = cur_mid;
cur_mid++; cur_mid++;
/* avoid 0xFFFF MID */
if (cur_mid == 0xffff)
cur_mid++;
/* /*
* This nested loop looks more expensive than it is. * This nested loop looks more expensive than it is.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment