Commit 086eec2d authored by Dan Carpenter's avatar Dan Carpenter Committed by Marc Zyngier

irqchip/mbigen: Checking for IS_ERR() instead of NULL

of_platform_device_create() returns NULL on error, it never returns
error pointers.

Fixes: ed2a1002 ('irqchip/mbigen: Handle multiple device nodes in a mbigen module')
Acked-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 074f23b6
...@@ -263,8 +263,8 @@ static int mbigen_device_probe(struct platform_device *pdev) ...@@ -263,8 +263,8 @@ static int mbigen_device_probe(struct platform_device *pdev)
parent = platform_bus_type.dev_root; parent = platform_bus_type.dev_root;
child = of_platform_device_create(np, NULL, parent); child = of_platform_device_create(np, NULL, parent);
if (IS_ERR(child)) if (!child)
return PTR_ERR(child); return -ENOMEM;
if (of_property_read_u32(child->dev.of_node, "num-pins", if (of_property_read_u32(child->dev.of_node, "num-pins",
&num_pins) < 0) { &num_pins) < 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment