Commit 090ffaa5 authored by Wendy Cheng's avatar Wendy Cheng Committed by Steven Whitehouse

[GFS2] inode size inconsistency

This should have been part of the NFS patch #1 but somehow I missed it
when packaging the patches. It is not a critical issue as the others (I
hope). RHEL 5.1 31.el5 kernel runs fine without this change.

Our truncate code is chopped into two parts, one for vfs inode changes
(in vmtruncate()) and one of gfs inode (in gfs2_truncatei()). These two
operatons are, unfortunately, not atomic. So it could happens that
vmtruncate() succeeds (inode->i_size is changed) but gfs2_truncatei
fails (say kernel temporarily out of memory). This would leave gfs inode
i_di.di_size out of sync with vfs inode i_size. It will later confuse
gfs2_commit_write() if a write is issued. Last time I checked, it will
cause file corruption.
Signed-off-by: default avatarS. Wendy Cheng <wcheng@redhat.com>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent 97d84836
...@@ -903,8 +903,8 @@ static int setattr_size(struct inode *inode, struct iattr *attr) ...@@ -903,8 +903,8 @@ static int setattr_size(struct inode *inode, struct iattr *attr)
} }
error = gfs2_truncatei(ip, attr->ia_size); error = gfs2_truncatei(ip, attr->ia_size);
if (error) if (error && (inode->i_size != ip->i_di.di_size))
return error; i_size_write(inode, ip->i_di.di_size);
return error; return error;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment