Commit 097e46d2 authored by Christian Lamparter's avatar Christian Lamparter Committed by Kalle Valo

ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats()

ath10k_wmi_tlv_op_pull_fw_stats() uses tb = ath10k_wmi_tlv_parse_alloc(...)
function, which allocates memory. If any of the three error-paths are
taken, this tb needs to be freed.
Signed-off-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 86176901
......@@ -1105,8 +1105,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k *ar,
struct ath10k_fw_stats_pdev *dst;
src = data;
if (data_len < sizeof(*src))
if (data_len < sizeof(*src)) {
kfree(tb);
return -EPROTO;
}
data += sizeof(*src);
data_len -= sizeof(*src);
......@@ -1126,8 +1128,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k *ar,
struct ath10k_fw_stats_vdev *dst;
src = data;
if (data_len < sizeof(*src))
if (data_len < sizeof(*src)) {
kfree(tb);
return -EPROTO;
}
data += sizeof(*src);
data_len -= sizeof(*src);
......@@ -1145,8 +1149,10 @@ static int ath10k_wmi_tlv_op_pull_fw_stats(struct ath10k *ar,
struct ath10k_fw_stats_peer *dst;
src = data;
if (data_len < sizeof(*src))
if (data_len < sizeof(*src)) {
kfree(tb);
return -EPROTO;
}
data += sizeof(*src);
data_len -= sizeof(*src);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment