Commit 09b9ddfa authored by Takashi Iwai's avatar Takashi Iwai

ALSA: pcm: Use krealloc() for resizing the rules array

Just a minor simplification.  Change from kcalloc() shouldn't matter
as each array element is fully initialized.
Reviewed-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 5730f9f7
...@@ -1129,16 +1129,12 @@ int snd_pcm_hw_rule_add(struct snd_pcm_runtime *runtime, unsigned int cond, ...@@ -1129,16 +1129,12 @@ int snd_pcm_hw_rule_add(struct snd_pcm_runtime *runtime, unsigned int cond,
if (constrs->rules_num >= constrs->rules_all) { if (constrs->rules_num >= constrs->rules_all) {
struct snd_pcm_hw_rule *new; struct snd_pcm_hw_rule *new;
unsigned int new_rules = constrs->rules_all + 16; unsigned int new_rules = constrs->rules_all + 16;
new = kcalloc(new_rules, sizeof(*c), GFP_KERNEL); new = krealloc(constrs->rules, new_rules * sizeof(*c),
GFP_KERNEL);
if (!new) { if (!new) {
va_end(args); va_end(args);
return -ENOMEM; return -ENOMEM;
} }
if (constrs->rules) {
memcpy(new, constrs->rules,
constrs->rules_num * sizeof(*c));
kfree(constrs->rules);
}
constrs->rules = new; constrs->rules = new;
constrs->rules_all = new_rules; constrs->rules_all = new_rules;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment