Commit 0a1e8258 authored by Chengguang Xu's avatar Chengguang Xu Committed by Theodore Ts'o

ext4: compare old and new mode before setting update_mode flag

If new mode is the same as old mode we don't have to reset
inode mode in the rest of the code, so compare old and new
mode before setting update_mode flag.
Signed-off-by: default avatarChengguang Xu <cgxu519@gmx.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent e647e291
...@@ -248,7 +248,8 @@ ext4_set_acl(struct inode *inode, struct posix_acl *acl, int type) ...@@ -248,7 +248,8 @@ ext4_set_acl(struct inode *inode, struct posix_acl *acl, int type)
error = posix_acl_update_mode(inode, &mode, &acl); error = posix_acl_update_mode(inode, &mode, &acl);
if (error) if (error)
goto out_stop; goto out_stop;
update_mode = 1; if (mode != inode->i_mode)
update_mode = 1;
} }
error = __ext4_set_acl(handle, inode, type, acl, 0 /* xattr_flags */); error = __ext4_set_acl(handle, inode, type, acl, 0 /* xattr_flags */);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment