Commit 0ae9c321 authored by Lukasz Luba's avatar Lukasz Luba Committed by MyungJoo Ham

PM / devfreq: exynos-events: change matching code during probe

The patch changes the way how the 'ops' gets populated for different
device versions. The matching function now uses 'of_device_id' in order
to identify the device type.
Signed-off-by: default avatarLukasz Luba <l.luba@partner.samsung.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
parent 23ca7d25
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of_address.h> #include <linux/of_address.h>
#include <linux/of_device.h>
#include <linux/platform_device.h> #include <linux/platform_device.h>
#include <linux/regmap.h> #include <linux/regmap.h>
#include <linux/suspend.h> #include <linux/suspend.h>
...@@ -20,6 +21,11 @@ ...@@ -20,6 +21,11 @@
#include "exynos-ppmu.h" #include "exynos-ppmu.h"
enum exynos_ppmu_type {
EXYNOS_TYPE_PPMU,
EXYNOS_TYPE_PPMU_V2,
};
struct exynos_ppmu_data { struct exynos_ppmu_data {
struct clk *clk; struct clk *clk;
}; };
...@@ -33,6 +39,7 @@ struct exynos_ppmu { ...@@ -33,6 +39,7 @@ struct exynos_ppmu {
struct regmap *regmap; struct regmap *regmap;
struct exynos_ppmu_data ppmu; struct exynos_ppmu_data ppmu;
enum exynos_ppmu_type ppmu_type;
}; };
#define PPMU_EVENT(name) \ #define PPMU_EVENT(name) \
...@@ -486,31 +493,23 @@ static const struct devfreq_event_ops exynos_ppmu_v2_ops = { ...@@ -486,31 +493,23 @@ static const struct devfreq_event_ops exynos_ppmu_v2_ops = {
static const struct of_device_id exynos_ppmu_id_match[] = { static const struct of_device_id exynos_ppmu_id_match[] = {
{ {
.compatible = "samsung,exynos-ppmu", .compatible = "samsung,exynos-ppmu",
.data = (void *)&exynos_ppmu_ops, .data = (void *)EXYNOS_TYPE_PPMU,
}, { }, {
.compatible = "samsung,exynos-ppmu-v2", .compatible = "samsung,exynos-ppmu-v2",
.data = (void *)&exynos_ppmu_v2_ops, .data = (void *)EXYNOS_TYPE_PPMU_V2,
}, },
{ /* sentinel */ }, { /* sentinel */ },
}; };
MODULE_DEVICE_TABLE(of, exynos_ppmu_id_match); MODULE_DEVICE_TABLE(of, exynos_ppmu_id_match);
static struct devfreq_event_ops *exynos_bus_get_ops(struct device_node *np)
{
const struct of_device_id *match;
match = of_match_node(exynos_ppmu_id_match, np);
return (struct devfreq_event_ops *)match->data;
}
static int of_get_devfreq_events(struct device_node *np, static int of_get_devfreq_events(struct device_node *np,
struct exynos_ppmu *info) struct exynos_ppmu *info)
{ {
struct devfreq_event_desc *desc; struct devfreq_event_desc *desc;
struct devfreq_event_ops *event_ops;
struct device *dev = info->dev; struct device *dev = info->dev;
struct device_node *events_np, *node; struct device_node *events_np, *node;
int i, j, count; int i, j, count;
const struct of_device_id *of_id;
events_np = of_get_child_by_name(np, "events"); events_np = of_get_child_by_name(np, "events");
if (!events_np) { if (!events_np) {
...@@ -518,7 +517,6 @@ static int of_get_devfreq_events(struct device_node *np, ...@@ -518,7 +517,6 @@ static int of_get_devfreq_events(struct device_node *np,
"failed to get child node of devfreq-event devices\n"); "failed to get child node of devfreq-event devices\n");
return -EINVAL; return -EINVAL;
} }
event_ops = exynos_bus_get_ops(np);
count = of_get_child_count(events_np); count = of_get_child_count(events_np);
desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL); desc = devm_kcalloc(dev, count, sizeof(*desc), GFP_KERNEL);
...@@ -526,6 +524,12 @@ static int of_get_devfreq_events(struct device_node *np, ...@@ -526,6 +524,12 @@ static int of_get_devfreq_events(struct device_node *np,
return -ENOMEM; return -ENOMEM;
info->num_events = count; info->num_events = count;
of_id = of_match_device(exynos_ppmu_id_match, dev);
if (of_id)
info->ppmu_type = (enum exynos_ppmu_type)of_id->data;
else
return -EINVAL;
j = 0; j = 0;
for_each_child_of_node(events_np, node) { for_each_child_of_node(events_np, node) {
for (i = 0; i < ARRAY_SIZE(ppmu_events); i++) { for (i = 0; i < ARRAY_SIZE(ppmu_events); i++) {
...@@ -543,7 +547,15 @@ static int of_get_devfreq_events(struct device_node *np, ...@@ -543,7 +547,15 @@ static int of_get_devfreq_events(struct device_node *np,
continue; continue;
} }
desc[j].ops = event_ops; switch (info->ppmu_type) {
case EXYNOS_TYPE_PPMU:
desc[j].ops = &exynos_ppmu_ops;
break;
case EXYNOS_TYPE_PPMU_V2:
desc[j].ops = &exynos_ppmu_v2_ops;
break;
}
desc[j].driver_data = info; desc[j].driver_data = info;
of_property_read_string(node, "event-name", &desc[j].name); of_property_read_string(node, "event-name", &desc[j].name);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment