Commit 0c2ed8ee authored by Anton Altaparmakov's avatar Anton Altaparmakov

NTFS: Remove unused function fs/ntfs/runlist.c::ntfs_rl_merge(). (Adrian Bunk)

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarAnton Altaparmakov <aia21@cantab.net>
parent 03e6e25b
...@@ -12,6 +12,10 @@ ToDo/Notes: ...@@ -12,6 +12,10 @@ ToDo/Notes:
OTOH, perhaps i_sem, which is held accross generic_file_write is OTOH, perhaps i_sem, which is held accross generic_file_write is
sufficient for synchronisation here. We then just need to make sure sufficient for synchronisation here. We then just need to make sure
ntfs_readpage/writepage/truncate interoperate properly with us. ntfs_readpage/writepage/truncate interoperate properly with us.
UPDATE: The above is all ok as it is due to i_sem held. The only
thing that needs to be checked is ntfs_writepage() which does not
hold i_sem. It cannot change i_size but it needs to cope with a
concurrent i_size change.
- Implement mft.c::sync_mft_mirror_umount(). We currently will just - Implement mft.c::sync_mft_mirror_umount(). We currently will just
leave the volume dirty on umount if the final iput(vol->mft_ino) leave the volume dirty on umount if the final iput(vol->mft_ino)
causes a write of any mirrored mft records due to the mft mirror causes a write of any mirrored mft records due to the mft mirror
...@@ -42,7 +46,7 @@ ToDo/Notes: ...@@ -42,7 +46,7 @@ ToDo/Notes:
mount time as this cannot work with the current implementation. mount time as this cannot work with the current implementation.
- Check for location of attribute name and improve error handling in - Check for location of attribute name and improve error handling in
general in fs/ntfs/inode.c::ntfs_read_locked_inode() and friends. general in fs/ntfs/inode.c::ntfs_read_locked_inode() and friends.
- In fs/ntfs/aops.c::ntfs_writepage(), if t he page is fully outside - In fs/ntfs/aops.c::ntfs_writepage(), if the page is fully outside
i_size, i.e. race with truncate, invalidate the buffers on the page i_size, i.e. race with truncate, invalidate the buffers on the page
so that they become freeable and hence the page does not leak. so that they become freeable and hence the page does not leak.
- Implement extension of resident files in the regular file write code - Implement extension of resident files in the regular file write code
...@@ -50,6 +54,8 @@ ToDo/Notes: ...@@ -50,6 +54,8 @@ ToDo/Notes:
this only works until the data attribute becomes too big for the mft this only works until the data attribute becomes too big for the mft
record after which we abort the write returning -EOPNOTSUPP from record after which we abort the write returning -EOPNOTSUPP from
ntfs_prepare_write(). ntfs_prepare_write().
- Remove unused function fs/ntfs/runlist.c::ntfs_rl_merge(). (Adrian
Bunk)
2.1.21 - Fix some races and bugs, rewrite mft write code, add mft allocator. 2.1.21 - Fix some races and bugs, rewrite mft write code, add mft allocator.
......
...@@ -139,30 +139,6 @@ static inline void __ntfs_rl_merge(runlist_element *dst, runlist_element *src) ...@@ -139,30 +139,6 @@ static inline void __ntfs_rl_merge(runlist_element *dst, runlist_element *src)
dst->length += src->length; dst->length += src->length;
} }
/**
* ntfs_rl_merge - test if two runlists can be joined together and merge them
* @dst: original, destination runlist
* @src: new runlist to merge with @dst
*
* Test if two runlists can be joined together. For this, their VCNs and LCNs
* must be adjacent. If they can be merged, perform the merge, writing into
* the destination runlist @dst.
*
* It is up to the caller to serialize access to the runlists @dst and @src.
*
* Return: TRUE Success, the runlists have been merged.
* FALSE Failure, the runlists cannot be merged and have not been
* modified.
*/
static inline BOOL ntfs_rl_merge(runlist_element *dst, runlist_element *src)
{
BOOL merge = ntfs_are_rl_mergeable(dst, src);
if (merge)
__ntfs_rl_merge(dst, src);
return merge;
}
/** /**
* ntfs_rl_append - append a runlist after a given element * ntfs_rl_append - append a runlist after a given element
* @dst: original runlist to be worked on * @dst: original runlist to be worked on
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment