Commit 0c884567 authored by Suresh Reddy's avatar Suresh Reddy Committed by David S. Miller

be2net: release mcc-lock in a failure case in be_cmd_notify_wait()

The mcc/mbox lock is not being released when be_cmd_copy() returns
an error.
Signed-off-by: default avatarSuresh Reddy <suresh.reddy@avagotech.com>
Signed-off-by: default avatarSathya Perla <sathya.perla@avagotech.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ae4a9d6a
...@@ -851,8 +851,10 @@ static int be_cmd_notify_wait(struct be_adapter *adapter, ...@@ -851,8 +851,10 @@ static int be_cmd_notify_wait(struct be_adapter *adapter,
return status; return status;
dest_wrb = be_cmd_copy(adapter, wrb); dest_wrb = be_cmd_copy(adapter, wrb);
if (!dest_wrb) if (!dest_wrb) {
return -EBUSY; status = -EBUSY;
goto unlock;
}
if (use_mcc(adapter)) if (use_mcc(adapter))
status = be_mcc_notify_wait(adapter); status = be_mcc_notify_wait(adapter);
...@@ -862,6 +864,7 @@ static int be_cmd_notify_wait(struct be_adapter *adapter, ...@@ -862,6 +864,7 @@ static int be_cmd_notify_wait(struct be_adapter *adapter,
if (!status) if (!status)
memcpy(wrb, dest_wrb, sizeof(*wrb)); memcpy(wrb, dest_wrb, sizeof(*wrb));
unlock:
be_cmd_unlock(adapter); be_cmd_unlock(adapter);
return status; return status;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment