Commit 0d9dc4b4 authored by Nathan Lynch's avatar Nathan Lynch Committed by Paul Mackerras

[POWERPC] lparcfg: Remove useless buffer allocation

The 'data' member of proc_ppc64_lparcfg is unused, but the lparcfg
module's init routine allocates 4K for it.

Remove the code which allocates and frees this buffer.
Signed-off-by: default avatarNathan Lynch <ntl@pobox.com>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent 24f1f175
...@@ -41,7 +41,6 @@ ...@@ -41,7 +41,6 @@
/* #define LPARCFG_DEBUG */ /* #define LPARCFG_DEBUG */
static struct proc_dir_entry *proc_ppc64_lparcfg; static struct proc_dir_entry *proc_ppc64_lparcfg;
#define LPARCFG_BUFF_SIZE 4096
/* /*
* Track sum of all purrs across all processors. This is used to further * Track sum of all purrs across all processors. This is used to further
...@@ -595,13 +594,6 @@ int __init lparcfg_init(void) ...@@ -595,13 +594,6 @@ int __init lparcfg_init(void)
ent = create_proc_entry("ppc64/lparcfg", mode, NULL); ent = create_proc_entry("ppc64/lparcfg", mode, NULL);
if (ent) { if (ent) {
ent->proc_fops = &lparcfg_fops; ent->proc_fops = &lparcfg_fops;
ent->data = kmalloc(LPARCFG_BUFF_SIZE, GFP_KERNEL);
if (!ent->data) {
printk(KERN_ERR
"Failed to allocate buffer for lparcfg\n");
remove_proc_entry("lparcfg", ent->parent);
return -ENOMEM;
}
} else { } else {
printk(KERN_ERR "Failed to create ppc64/lparcfg\n"); printk(KERN_ERR "Failed to create ppc64/lparcfg\n");
return -EIO; return -EIO;
...@@ -613,10 +605,8 @@ int __init lparcfg_init(void) ...@@ -613,10 +605,8 @@ int __init lparcfg_init(void)
void __exit lparcfg_cleanup(void) void __exit lparcfg_cleanup(void)
{ {
if (proc_ppc64_lparcfg) { if (proc_ppc64_lparcfg)
kfree(proc_ppc64_lparcfg->data);
remove_proc_entry("lparcfg", proc_ppc64_lparcfg->parent); remove_proc_entry("lparcfg", proc_ppc64_lparcfg->parent);
}
} }
module_init(lparcfg_init); module_init(lparcfg_init);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment