Commit 0fc86eca authored by Henrik Rydberg's avatar Henrik Rydberg Committed by Guenter Roeck

hwmon: (applesmc) Silence uninitialized warnings

Some error paths do not set a result, leading to the (false)
assumption that the value may be used uninitialized. Set results for
those paths as well.
Signed-off-by: default avatarHenrik Rydberg <rydberg@euromail.se>
Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 7599d32b
...@@ -344,8 +344,10 @@ static int applesmc_get_lower_bound(unsigned int *lo, const char *key) ...@@ -344,8 +344,10 @@ static int applesmc_get_lower_bound(unsigned int *lo, const char *key)
while (begin != end) { while (begin != end) {
int middle = begin + (end - begin) / 2; int middle = begin + (end - begin) / 2;
entry = applesmc_get_entry_by_index(middle); entry = applesmc_get_entry_by_index(middle);
if (IS_ERR(entry)) if (IS_ERR(entry)) {
*lo = 0;
return PTR_ERR(entry); return PTR_ERR(entry);
}
if (strcmp(entry->key, key) < 0) if (strcmp(entry->key, key) < 0)
begin = middle + 1; begin = middle + 1;
else else
...@@ -364,8 +366,10 @@ static int applesmc_get_upper_bound(unsigned int *hi, const char *key) ...@@ -364,8 +366,10 @@ static int applesmc_get_upper_bound(unsigned int *hi, const char *key)
while (begin != end) { while (begin != end) {
int middle = begin + (end - begin) / 2; int middle = begin + (end - begin) / 2;
entry = applesmc_get_entry_by_index(middle); entry = applesmc_get_entry_by_index(middle);
if (IS_ERR(entry)) if (IS_ERR(entry)) {
*hi = smcreg.key_count;
return PTR_ERR(entry); return PTR_ERR(entry);
}
if (strcmp(key, entry->key) < 0) if (strcmp(key, entry->key) < 0)
end = middle; end = middle;
else else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment