Commit 10f39758 authored by Bernard Zhao's avatar Bernard Zhao Committed by Alex Deucher

drm/amdgpu: cleanup coding style in amdkfd a bit

Make the code a bit more readable by using a common
error handling pattern.
Signed-off-by: default avatarBernard Zhao <bernard@vivo.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e05185b3
...@@ -660,15 +660,15 @@ static int reserve_bo_and_vm(struct kgd_mem *mem, ...@@ -660,15 +660,15 @@ static int reserve_bo_and_vm(struct kgd_mem *mem,
ret = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->list, ret = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->list,
false, &ctx->duplicates); false, &ctx->duplicates);
if (!ret) if (ret) {
ctx->reserved = true; pr_err("Failed to reserve buffers in ttm.\n");
else {
pr_err("Failed to reserve buffers in ttm\n");
kfree(ctx->vm_pd); kfree(ctx->vm_pd);
ctx->vm_pd = NULL; ctx->vm_pd = NULL;
return ret;
} }
return ret; ctx->reserved = true;
return 0;
} }
/** /**
...@@ -733,17 +733,15 @@ static int reserve_bo_and_cond_vms(struct kgd_mem *mem, ...@@ -733,17 +733,15 @@ static int reserve_bo_and_cond_vms(struct kgd_mem *mem,
ret = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->list, ret = ttm_eu_reserve_buffers(&ctx->ticket, &ctx->list,
false, &ctx->duplicates); false, &ctx->duplicates);
if (!ret)
ctx->reserved = true;
else
pr_err("Failed to reserve buffers in ttm.\n");
if (ret) { if (ret) {
pr_err("Failed to reserve buffers in ttm.\n");
kfree(ctx->vm_pd); kfree(ctx->vm_pd);
ctx->vm_pd = NULL; ctx->vm_pd = NULL;
return ret;
} }
return ret; ctx->reserved = true;
return 0;
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment